Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpful note on replace-provider #816

Merged
merged 3 commits into from
Jun 18, 2021
Merged

Helpful note on replace-provider #816

merged 3 commits into from
Jun 18, 2021

Conversation

glerb
Copy link
Contributor

@glerb glerb commented Jun 12, 2021

Solving this problem took me hours, and would've taken more but for #652

@glerb
Copy link
Contributor Author

glerb commented Jun 12, 2021

And the problem is actually still not completely solved. I get a diff on plan for every resource created from a module (I only have one module). I've added the terraform { required_providers {}} block in the module.

Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thank you and apologies that you lost time on this one.

Hoping this note helps others avoid the same in the future.

@jcudit jcudit added this to the v4.12.0 milestone Jun 15, 2021
@jcudit jcudit merged commit ea1a776 into integrations:master Jun 18, 2021
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
* Helpful note on replace-provider

* More accurate description of problem

* Typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants